Having trouble getting PedOnDeath triggers to work

[Binary101010]

Trying to put together some basic missions for a research study I'm helping with. The current intent is to simply spawn two peds, have one start attacking the other, and have the player intervene to protect the one being bullied. I'd also like a text message to come up when the bully is beaten up.

I've gotten everything working except that last part. When the player intervenes and beats up the bully... nothing happens. No text or anything. What am I missing?

Code: [Select]

ImportScript("\\Library\\LibTable.lua") -- imports the LibTable library
ImportScript("\\Library\\LibPed.lua") -- imports the LibPed library
local l_0_0 = false
 
MissionSetup = function() -- basic mission setup function which is used in almost all bully scripts
  local l_1_0 = 270 -- X coords
  local l_1_1 = -110 -- Y coords
  local l_1_2 = 6.4000000953674 -- Z coords
  local Algernon = Nil -- Initialize bullied char
  local Damon = Nil -- Initialize bully
 
  DisablePunishmentSystem(true) -- Necessary to keep the prefects from interfering
  PlayerSetHealth(200) -- gives the player 200 health
  AreaTransitionXYZ(0, l_1_0, l_1_1, l_1_2) -- Moves player to outside boys' dorm
  TextPrintString("Algernon is one of the geeks at school. He needs protection from Damon, the jock who has been bullying him.", 4, 1) -- Posts red text on screen
  Algernon = PedCreateXYZ(4,265,-110,6.4000000953674) -- Spawn bully target
  Damon = PedCreateXYZ(12,262,-110,6.4000000953674) -- Spawn bully
  PedRecruitAlly(Algernon,gplayer) -- Second character assigned to bodyguard first
  PedAttack(Damon, Algernon, 1) -- Bully attacks target
  PedShowHealthBar(Algernon, true, "N_Algernon", true) -- Display Algernon's health bar
end

MissionCleanup = function()
end -- end statement
 
 F_MissionCheck = function()
 if PedIsDead(Damon) then
  TextPrintString("Congratulations! Algernon is safe for now thanks to your intervention.") -- This is where I need help, this text never appears
  end
  end
 
main = function() -- Main mission function
  repeat
  F_MissionCheck()
  Wait(2000)
  until not Alive
  end


[Bellic19]

You haven't included a font size and shit. Try this instead

Code: [Select]

ImportScript("\\Library\\LibTable.lua") -- imports the LibTable library
ImportScript("\\Library\\LibPed.lua") -- imports the LibPed library
local l_0_0 = false
 
MissionSetup = function() -- basic mission setup function which is used in almost all bully scripts
  local l_1_0 = 270 -- X coords
  local l_1_1 = -110 -- Y coords
  local l_1_2 = 6.4000000953674 -- Z coords
  local Algernon = Nil -- Initialize bullied char
  local Damon = Nil -- Initialize bully
 
  DisablePunishmentSystem(true) -- Necessary to keep the prefects from interfering
  PlayerSetHealth(200) -- gives the player 200 health
  AreaTransitionXYZ(0, l_1_0, l_1_1, l_1_2) -- Moves player to outside boys' dorm
  TextPrintString("Algernon is one of the geeks at school. He needs protection from Damon, the jock who has been bullying him.", 4, 1) -- Posts red text on screen
  Algernon = PedCreateXYZ(4,265,-110,6.4000000953674) -- Spawn bully target
  Damon = PedCreateXYZ(12,262,-110,6.4000000953674) -- Spawn bully
  PedRecruitAlly(Algernon,gplayer) -- Second character assigned to bodyguard first
  PedAttack(Damon, Algernon, 1) -- Bully attacks target
  PedShowHealthBar(Algernon, true, "N_Algernon", true) -- Display Algernon's health bar
end

MissionCleanup = function()
end -- end statement
 
 F_MissionCheck = function()
 if PedIsDead(Damon) then
  TextPrintString("Congratulations! Algernon is safe for now thanks to your intervention.", 4, 1)
   Wait(5000)
  end
  end
 
main = function() -- Main mission function
  repeat
  F_MissionCheck()
  Wait(2000)
  until not Alive
  end

That should work. Welcome to the board BTW!

[Binary101010]

Well, the lack of the font info was definitely a problem. Can't believe I missed that as I got it right on the text at the beginning of the mission. And nobody else working on this project with me has even as much of a clue about LUA as I do (which isn't much).

However, it looks like there's a different problem now, as the "Congratulations" test is appearing immediately on the beginning of the mission. So I have to figure there's something about the PedIsDead trigger that's not working right. Any ideas?

[Bellic19]

alittle more info please. is it appearing then disappearing or is it constant?

[Binary101010]

Looks like it stays on screen for somewhere between 3-4 seconds, disappears for 3 seconds, comes back for another 3-4 seconds, disappears for 3 seconds, and so on.

[AlphaTech]

You really should check my mission scripting tutorial.
So basically you do this,
 
To tell you a few things make sure to follow my scripting tutorial entirely. The argument with if is always used to ask the game wether something is valid or not.
 
Anything can be used for checking

Code: [Select]

if DuckisGoose = false  and DuckisFound = false and PedIsValid(Goose) then
--Duck Found
end
With false the argument is always set to true if your trying to run something once. Running false multiple times like this

Code: [Select]

function CallPreppiesToHelp()
PreppiesHelp = false
end

function CallPreppiesToHelp()
PreppiesHelp = false
PedAddPedToIgnoreList(Preppy1)
end

function CallPreppiesToHelp2()
PreppiesHelp = true
PedAttack(Preppy1)
PreppiesHelp = false
end

Code: [Select]

function MissionSetup()
AreaTransitionXYZ(0, 270, -110, 6.4000000953674)
  DisablePunishmentSystem(true)
  AreaDisableAllPatrolPaths()
  DisablePunishmentSystem(false)
Algernon = PedCreateXYZ(4,265,-110,6.4000000953674) -- Spawn bully target
  Damon = PedCreateXYZ(12,262,-110,6.4000000953674) --Spawn bully
SpawnCallToBully()
end

function SpawnCallToBully()
  local x,y = 4,256
  local r1 = x + 1.5
  local r2 = y + 1.5
  local r3 = x - 1.5
  local r4 = y - 1.5
  repeat
    Wait(0)
  until PedInRectangle(gPlayer,r1,r2,r3,r4)
  Wait(1500)
 TextPrintString("Algernon is one of the geeks at school. He needs protection from Damon, the jock who has been bullying him.", 4, 1)
Wait(4000)
PedRecruitAlly(Algernon,gPlayer)
 PedShowHealthBar(Algernon, true, "N_Algernon", true)
PedAttack(Damon, Algernon, 1)
IsBully = false
end

function BullyDefeated()
if PedIsDead(Damon) and IsBully = false then
IsBully = true
TextPrintString("Congratulations! Algernon is safe for now thanks to your intervention.",4,1)
Wait(6000)
MissionSucceed(true, false, false)
CameraSetWidescreen(true) 
Wait(4000)
CameraFade(500, 0)
Wait(500)
CameraAllowChange(true)
SoundSetAudioFocusPlayer()
CameraReturnToPlayer()
CameraReset()
CameraSetWidescreen(false)
  PlayerSetHealth(800)
end

main = function()
repeat
BullyDefeated()
Wait(0)
until not Alive
end


[Binary101010]

DaBOSS54320, thank you for the very helpful notes. I will keep all of your advice in mind as I am working on the project.

I tried running the script with your modifications through the game. Unfortunately, I seem to be having a similar problem to before. The "congratulations" text is appearing on the screen immediately after starting the mission. I am also getting the standard yellow "You Passed" text for mission success immediately after that. So it would appear that the mission success trigger is working correctly, but the PedIsDead(Damon) trigger is firing off immediately at the beginning of the mission before I've had a chance to even lay a hand on him.

[AlphaTech]

Code: [Select]

if DuckisGoose = false  and DuckisFound = false and PedIsValid(Goose) then
--Duck Found
end

THIS ISN'T RIGHT! Would it kill ya to test your scripts before posting them? You need TWO equal signs for comparison, one equal sign is for assignment. I'm sorry but you do this constantly. Please, make sure you know what you're talking about before posting all this invalid code and confusing newbies.

My fucking bad I made a mistake Christ I will refix the script just didn't have time to.  I also added a blip for you to use so players and yourself could see where to go to.

I tried running the script with your modifications through the game. Unfortunately, I seem to be having a similar problem to before. The "congratulations" text is appearing on the screen immediately after starting the mission. I am also getting the standard yellow "You Passed" text for mission success immediately after that. So it would appear that the mission success trigger is working correctly, but the PedIsDead(Damon) trigger is firing off immediately at the beginning of the mission before I've had a chance to even lay a hand on him.

So here is the fix, also all peds must be spawned before running the PedIsDead

Code: [Select]

function MissionSetup()
AreaTransitionXYZ(0, 270, -110, 6.4000000953674)
  DisablePunishmentSystem(true)
  AreaDisableAllPatrolPaths()
  DisablePunishmentSystem(false)
Algernon = PedCreateXYZ(4,265,-110,6.4000000953674) -- Spawn bully target
  Damon = PedCreateXYZ(12,262,-110,6.4000000953674) --Spawn bully
MissionBlip = BlipAddXYZ(12,262,-110,6.4000000953674,0)
SpawnCallToBully()
end

function SpawnCallToBully()
  local x,y = 4,256
  local r1 = x + 1.5
  local r2 = y + 1.5
  local r3 = x - 1.5
  local r4 = y - 1.5
  repeat
    Wait(0)
  until PedInRectangle(gPlayer,r1,r2,r3,r4)
  Wait(1500)
BlipRemove(MissionBlip)
 TextPrintString("Algernon is one of the geeks at school. He needs protection from Damon, the jock who has been bullying him.", 4, 1)
Wait(4000)
PedRecruitAlly(Algernon,gPlayer)
 PedShowHealthBar(Algernon, true, "N_Algernon", true)
PedAttack(Damon, Algernon, 1)
IsBully = false
end

function BullyDefeated()
if PedIsDead(Damon) and IsBully == false then
IsBully = true
TextPrintString("Congratulations! Algernon is safe for now thanks to your intervention.",4,1)
Wait(6000)
MissionSucceed(true, false, false)
CameraSetWidescreen(true) 
Wait(4000)
CameraFade(500, 0)
Wait(500)
CameraAllowChange(true)
SoundSetAudioFocusPlayer()
CameraReturnToPlayer()
CameraReset()
CameraSetWidescreen(false)
  PlayerSetHealth(800)
end

main = function()
repeat
BullyDefeated()
Wait(0)
until not Alive
end
Try running my script and looking at my tutorials it should work correctly now I just had an error with the (=) their should always be (==) instead of one looking like this. if PedIsDead(Damon) and IsBully == false then not like this if PedIsDead(Damon) and IsBully = false then
All blips are used like this TestBlip = BlipAddXYZ(X,Y,Z,0) (0 is the small Yellow X appearing on the map) (The blip's location should always be the same as the objective location not any wear else. If you script the blip in another location you may mess up player's in finding certain things.)

[Binary101010]

Yep, that was the problem! Removed the local from the lines defining the other peds and everything worked exactly as expected. I now have a fully working one-part mission. Now to expand it out into two or three parts. I'll definitely check back in if I need help. Thanks again!